fix(people): resolve type errors#585
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
jpoehnelt
left a comment
jpoehnelt
left a comment
There was a problem hiding this comment.
LGTM! Excellent type definitions and safety checks.
Resolves TypeScript errors in the `people/quickstart/quickstart.gs` file by: - Adding JSDoc annotations for `Name`, `Person`, `Connection` and `EmailAddress` types. - Adding a check to ensure the `People` advanced service is enabled. - Removing an unhelpful try/catch block. - Improving the logic to safely access `displayName`.
jpoehnelt
force-pushed
the
fix-people-type-errors
branch
from
61d6fbd to
2ddf01e
Compare
1 participant
This change resolves TypeScript type-checking errors in the 'people/quickstart' sample. It adds JSDoc annotations for custom types, including
EmailAddress, includes a check for the People advanced service, removes an unhelpful try/catch block, and improves the robustness of the connection name logging.PR created automatically by Jules for task 7156280403700994901 started by @jpoehnelt